lkml.org 
[lkml]   [2003]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add checkstack Makefile target
On Wed, Mar 05, 2003 at 03:51:49PM +0100, J??rn Engel wrote:

> > Since the above is now architecture independent, better locate it in
> > the top level Makefile.
>
> But the perl script itself breaks for anything but i386 and ppc at the
> moment, so I keep the changes in the arch Makefiles. Ultimately this
> should support all architectures and go to the top level, though.

There is no reason to put this in the arch specific makefiles.
You error out in a nice way in checkstack.pl anyway.
And architecture specific requirements shall be kept on a minimum.
Realise that the changes get even smaller, and only one file needs
to be touched to support a new architecture.


> +checkstack: vmlinux ***FORCE***
> + $(OBJDUMP) -d vmlinux | \
> + $(PERL) scripts/checkstack.pl $(ARCH)

You need FORCE to make sure the rule is actually executed.
And we have a variable that points to perl, use that one.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:2.032 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site