Messages in this thread | | | Date | Wed, 5 Mar 2003 18:51:49 +0000 | From | Christoph Hellwig <> | Subject | Re: ipsec-tools 0.1 + kernel 2.5.64 |
| |
On Wed, Mar 05, 2003 at 01:43:30PM -0500, Derek Atkins wrote: > Well, the problem is that the replacement function is only valid on > Linux, so I need to have the <OS> test in there anyways.
It's probably not valid on Linux but on OSes that support the functionality you use to implement it. It might e.g. work on the Hurd that uses old Linux networking code.
> It may be > "bad style", but the test needs to exist _somewhere_. Besides, I've > never been one to be convinced to do something purely based on > stylistic arguments. Give me a real technical reason why it needs to > be different and I'll consider changing it.
Checking for OSes is wrong because you couldn't care less for the OS, you care for the functionality that is provided. This is the nice idea behind autoconf (the implementation of autoconf is a completly different issue, though).
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |