lkml.org 
[lkml]   [2003]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][ATM] make atm (and clip) modular + try_module_get()
On Wed, 5 Mar 2003, chas williams wrote:

> In message <Pine.LNX.4.44.0303031825240.16397-100000@chaos.physics.uiowa.edu>,K
> ai Germaschewski writes:
> >Not terribly important, but you can write this as:
> >obj-$(CONFIG_ATM) += atm.o
> >atm-y += addr.o pvc.o signaling.o svc.o ...
> >atm-$(CONFIG_PROC_FS) += proc.o
>
> after looking at some other examples, i guess i like this even better:
>
>
> ipcommon-obj-$(subst m,y,$(CONFIG_ATM_CLIP)) := ipcommon.o
> ipcommon-obj-$(subst m,y,$(CONFIG_NET_SCH_ATM)) := ipcommon.o
>
> atm-objs := addr.o pvc.o signaling.o svc.o common.o atm_misc.o raw.o resources.o $(ipcommon-obj-y)
>
> obj-$(CONFIG_ATM) += atm.o
> atm-$(CONFIG_PROC_FS) += proc.o

Well, this is IMO confusing since now you're using two different ways to
add to atm.o in the same Makefile.

The preferred way would be:

obj-$(CONFIG_ATM) += atm.o

atm-y := addr.o pvc.o signaling.o svc.o common.o atm_misc.o raw.o resources.o
atm-$(subst m,y,$(CONFIG_ATM_CLIP)) += ipcommon.o
atm-$(subst m,y,$(CONFIG_NET_SCH_ATM)) += ipcommon.o
atm-$(CONFIG_PROC_FS) += proc.o

You could write this as

obj-$(CONFIG_ATM) += atm.o

atm-obj-$(subst m,y,$(CONFIG_ATM_CLIP)) += ipcommon.o
atm-obj-$(subst m,y,$(CONFIG_NET_SCH_ATM)) += ipcommon.o
atm-obj-$(CONFIG_PROC_FS) += proc.o
atm-objs := addr.o pvc.o signaling.o svc.o common.o atm_misc.o raw.o \
resources.o $(atm-obj-y)

But I'd really like you to use the former. I know this is currently
handled inconsistently throughout the Makefiles, at some point I'll
hopefully get around to converting things to the "new-style" above.

--Kai


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.037 / U:1.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site