lkml.org 
[lkml]   [2003]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type]
    Date
    I think the problem is platform_match() :

    static int platform_match(struct device * dev, struct device_driver * drv)
    {
    return 0;
    }

    which effectively makes driver binding impossible, pcmcia_socket_class->add_device isn't called.

    --Mika


    >
    > Lähettäjä: Dominik Brodowski <linux@brodo.de>
    > Päiväys: 2003/03/04 ti AM 09:39:15 GMT+02:00
    > Vastaanottaja: torvalds@transmeta.com, jt@hpl.hp.com
    > Kopio: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
    > Patrick Mochel <mochel@osdl.org>
    > Aihe: [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type]
    >
    > Hi,
    >
    > On Mon, Mar 03, 2003 at 05:30:20PM -0800, Jean Tourrilhes wrote:
    > > Hi,
    > >
    > > I'm trying to get i82365 to work again, because I need to test
    > <snip>
    > > Intel PCIC probe:
    > > Vadem VG-469 ISA-to-PCMCIA at port 0x3e0 ofs 0x00, 2 sockets
    > > host opts [0]: none
    > > host opts [1]: none
    > > ISA irqs (scanned) = 4,5 polling interval = 1000 ms
    > > ds: no socket drivers loaded!
    >
    > Sorry about that -- I mixed up the ordering of initializing the class data
    > and registering the platform device. Here's a bugfix for the three pcmcia
    > socket drivers that are platform devices.
    >
    > Please apply,
    > Dominik
    >
    > diff -ruN linux-original/drivers/pcmcia/hd64465_ss.c linux/drivers/pcmcia/hd64465_ss.c
    > --- linux-original/drivers/pcmcia/hd64465_ss.c 2003-03-04 08:27:06.000000000 +0100
    > +++ linux/drivers/pcmcia/hd64465_ss.c 2003-03-04 08:30:37.000000000 +0100
    > @@ -1070,8 +1070,8 @@
    > }
    >
    > /* hd64465_io_debug = 0; */
    > - platform_device_register(&hd64465_device);
    > hd64465_device.dev.class_data = &hd64465_data;
    > + platform_device_register(&hd64465_device);
    >
    > return 0;
    > }
    > diff -ruN linux-original/drivers/pcmcia/i82365.c linux/drivers/pcmcia/i82365.c
    > --- linux-original/drivers/pcmcia/i82365.c 2003-03-04 08:27:06.000000000 +0100
    > +++ linux/drivers/pcmcia/i82365.c 2003-03-04 08:28:28.000000000 +0100
    > @@ -1628,11 +1628,11 @@
    > request_irq(cs_irq, pcic_interrupt, 0, "i82365", pcic_interrupt);
    > #endif
    >
    > - platform_device_register(&i82365_device);
    > -
    > i82365_data.nsock = sockets;
    > i82365_device.dev.class_data = &i82365_data;
    >
    > + platform_device_register(&i82365_device);
    > +
    > /* Finally, schedule a polling interrupt */
    > if (poll_interval != 0) {
    > poll_timer.function = pcic_interrupt_wrapper;
    > diff -ruN linux-original/drivers/pcmcia/tcic.c linux/drivers/pcmcia/tcic.c
    > --- linux-original/drivers/pcmcia/tcic.c 2003-03-04 08:27:06.000000000 +0100
    > +++ linux/drivers/pcmcia/tcic.c 2003-03-04 08:30:03.000000000 +0100
    > @@ -452,8 +452,6 @@
    > sockets++;
    > }
    >
    > - platform_device_register(&tcic_device);
    > -
    > switch (socket_table[0].id) {
    > case TCIC_ID_DB86082:
    > printk("DB86082"); break;
    > @@ -527,6 +525,8 @@
    > tcic_data.nsock = sockets;
    > tcic_device.dev.class_data = &tcic_data;
    >
    > + platform_device_register(&tcic_device);
    > +
    > return 0;
    >
    > } /* init_tcic */
    > -
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.026 / U:1.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site