lkml.org 
[lkml]   [2003]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add checkstack Makefile target
On Tue, Mar 04, 2003 at 11:57:39AM +0100, J??rn Engel wrote:

A few comments to the Makefile changes..

> diff -Naur linux-2.5.63/arch/i386/Makefile linux-2.5.63-checkstack/arch/i386/Makefile
> --- linux-2.5.63/arch/i386/Makefile Mon Feb 24 20:05:15 2003
> +++ linux-2.5.63-checkstack/arch/i386/Makefile Tue Mar 4 11:51:11 2003
> @@ -124,3 +124,12 @@
> echo ' install to $$(INSTALL_PATH) and run lilo'
> endef
>
> +CLEAN_FILES += $(TOPDIR)/scripts/checkstack_i386.pl
Do not use TOPDIR.
> +CLEAN_FILES += scripts/checkstack_i386.pl
Is preferred.

> +
> +$(TOPDIR)/scripts/checkstack_i386.pl: $(TOPDIR)/scripts/checkstack.pl
> + (cd $(TOPDIR)/scripts/ && ln -s checkstack.pl checkstack_i386.pl)
There is no need to use the symlink trick.
Just pass the architecture as first mandatory parameter.
Something like
checkstack: vmlinux FORCE
$(OBJDUMP) -d vmlinux | scripts/checkstack.pl $(ARCH)

Note that I skipped grep. Perl is good at regular expressions, and
the perl scripts already know the architecture so you can do the job there.
Since the above is now architecture independent, better locate it in
the top level Makefile.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.075 / U:1.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site