lkml.org 
[lkml]   [2003]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] remap-file-pages-2.5.63-A0

On Mon, 3 Mar 2003, Linus Torvalds wrote:

> > the attached patch, against BK-curr, is a preparation to make
> > remap_file_pages() usable on swappable vmas as well. When 'swapping out'
> > shared-named mappings the page offset is written into the pte.
> >
> > it takes one bit from the swap-type bits, otherwise it does not change the
> > pte layout - so it should be easy to adapt any other architecture to this
> > change as well. (this patch does not introduce the protection-bits-in-pte
> > approach used in my previous patch.)
>
> One question: Why?
>
> What's wrong with just using the value we use now (0), and just
> calculating the page from the vma/offset information? Why hide the
> offset in the page tables, when there is no need for it?

you mean why in the normal, linear mapping case? No reason, just for
testing. At zap-time we could test whether that pte is linear or not, and
only store it in the swap entry as a file-pte if it's nonlinear.

for swappable sys_file_remap_pages() support it's necessary though, as
they break up the linear mapping without splitting up the vma into
zillions of pieces.

Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.035 / U:1.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site