Messages in this thread | | | Date | Sat, 29 Mar 2003 20:14:13 -0000 | From | Alex Bligh - linux-kernel <> | Subject | Re: [TRIVIAL] Cleanup in fs/devpts/inode.c |
| |
--On 29 March 2003 18:29 +0000 john@grabjohn.com wrote:
>> this patch un-complicates a small piece of code of the dev/pts >> filesystem and decreases the size of the object code by 8 bytes >> for my build. Yay! :) > >> - err = PTR_ERR(devpts_mnt); >> - if (!IS_ERR(devpts_mnt)) >> - err = 0; >> + if (IS_ERR(devpts_mnt)) >> + err = PTR_ERR(devpts_mnt); > > Why not use > > err = (IS_ERR(devpts_mnt) ? err = 0 : PTR_ERR(devpts_mnt));
Perhaps because it inverts the logic, and has a superfluous assignment causing a warning? :-) I think you meant:
err = IS_ERR(devpts_mnt) ? PTR_ERR(devpts_mnt) : 0;
-- Alex Bligh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |