Messages in this thread | | | Date | Sat, 29 Mar 2003 00:10:07 -0500 | From | Jeff Garzik <> | Subject | Re: init_etherdev conversion for sb1000 |
| |
davej@codemonkey.org.uk wrote: > Also plugs leak by kfree'ing dev_sb1000 on exit. > > diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/sb1000.c linux-2.5/drivers/net/sb1000.c > --- bk-linus/drivers/net/sb1000.c 2003-03-08 09:57:16.000000000 +0000 > +++ linux-2.5/drivers/net/sb1000.c 2003-03-17 23:42:27.000000000 +0000 > @@ -218,7 +218,7 @@ sb1000_probe(struct net_device *dev) > "S/N %#8.8x, IRQ %d.\n", dev->name, dev->base_addr, > dev->mem_start, serial_number, dev->irq); > > - dev = init_etherdev(dev, 0); > + dev = init_etherdev(dev, sizeof(struct sb1000_private));
nope -- init_etherdev only allocs when it's first arg is NULL.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |