Messages in this thread | | | Subject | Re: [Linux-fbdev-devel] Much better framebuffer fixes. | From | Antonino Daplas <> | Date | 28 Mar 2003 03:15:23 +0800 |
| |
On Thu, 2003-03-27 at 17:18, Geert Uytterhoeven wrote: > On Thu, 27 Mar 2003, James Simmons wrote: > > drivers/video/logo/logo.c | 69 +++++------ > > Are you sure the change from logo type to logo depth in (fb_)find_logo() won't > have any side effects? After this change, you may receive a different type of > logo than you requested. >
I agree. Take the case of Directcolor. At 16-bpp, it needs linux_logo_vga16, not linux_logo_clut224. Also, monochrome at 8bpp needs linux_logo_mono, certainly not linux_logo_clut224. There are obviously other similar cases.
I think the original logo code in both logo.c and fbmem.c, though a bit more confusing, provides better ways of choosing the correct logo.
Tony
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |