Messages in this thread | | | Date | Thu, 27 Mar 2003 10:04:52 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: BUG or not? GFP_KERNEL with interrupts disabled. |
| |
On Thu, 27 Mar 2003, David S. Miller wrote: > > I do agree that we should obviously not run bottom halves with > interrupts disabled > > Ok, so can we add a: > > if (irqs_disabled()) > BUG(); > > check to do_softirq()?
I'd suggest making it a counting warning (with a static counter per local-bh-enable macro expansion) and adding it to local_bh_enable() - otherwise it will only BUG() when the (potentially rare) condition happens - instead of always giving a nice backtrace of exact problem spots.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |