Messages in this thread | | | Date | Thu, 27 Mar 2003 12:28:13 -0500 | From | Pete Zaitcev <> | Subject | Re: [PATCH] asm offsets for i386 |
| |
> [Resend] > > This patch creates an asm-offsets.c file for i386, and removes the > hardcoded constants from several asm files. > > -- > Brian Gerst
Doesn't seem to be worth the trouble because thread_info is a small structure, not embedded into a big structure as thread_struct was. DaveM removed the automatic offset generation on sparc64 and I am thinking to do the same on sparc.
I'm not surprised that nobody answered, the patch seems to be rather pointless.
We might want to add something like this:
if (TI_CPU != offsetof(struct thread_info, cpu) || TI_PREEMPT != offsetof(struct thread_info, preempt_count) || TI_SOFTIRQ != offsetof(struct thread_info, softirq_count) || TI_HARDIRQ != offsetof(struct thread_info, hardirq_count)) thread_info_offsets_are_bolixed_linus();
It gives out an link time error.
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |