lkml.org 
[lkml]   [2003]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] swap 08/13 rmap comments
    Update a few locking comments in rmap.c.

    --- swap07/mm/rmap.c Tue Mar 25 20:44:02 2003
    +++ swap08/mm/rmap.c Tue Mar 25 20:44:13 2003
    @@ -14,8 +14,8 @@
    /*
    * Locking:
    * - the page->pte.chain is protected by the PG_chainlock bit,
    - * which nests within the zone->lru_lock, then the
    - * mm->page_table_lock, and then the page lock.
    + * which nests within the the mm->page_table_lock,
    + * which nests within the page lock.
    * - because swapout locking is opposite to the locking order
    * in the page fault path, the swapout path uses trylocks
    * on the mm->page_table_lock
    @@ -584,9 +584,8 @@
    * table entry mapping a page. Because locking order here is opposite
    * to the locking order used by the page fault path, we use trylocks.
    * Locking:
    - * zone->lru_lock page_launder()
    - * page lock page_launder(), trylock
    - * pte_chain_lock page_launder()
    + * page lock shrink_list(), trylock
    + * pte_chain_lock shrink_list()
    * mm->page_table_lock try_to_unmap_one(), trylock
    */
    static int FASTCALL(try_to_unmap_one(struct page *, pte_addr_t));
    @@ -673,8 +672,8 @@
    * @page: the page to get unmapped
    *
    * Tries to remove all the page table entries which are mapping this
    - * page, used in the pageout path. Caller must hold zone->lru_lock
    - * and the page lock. Return values are:
    + * page, used in the pageout path. Caller must hold the page lock
    + * and its pte chain lock. Return values are:
    *
    * SWAP_SUCCESS - we succeeded in removing all mappings
    * SWAP_AGAIN - we missed a trylock, try again later
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:34    [W:0.021 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site