Messages in this thread | | | Date | Mon, 24 Mar 2003 19:53:08 -0800 | From | Greg KH <> | Subject | Re: i2c-via686a driver |
| |
On Sun, Mar 23, 2003 at 10:38:43PM +0100, Jan Dittmer wrote: > Christoph Hellwig wrote: > >On Sun, Mar 23, 2003 at 09:36:10PM +0100, Dominik Kubla wrote: > > > >>Why? It's a valid C99 feature and since the kernel already uses C99 > >>initializers it won't compile with compilers that choke on C99 comments > >>anyway. > > > > > >Because there's a strong preference for traditional C style in the kernel. > >typedefs are also a valid C feature and we try to avoid them. > > > Anyway, here is a corrected version. > Jan
Looks good, thanks.
But could you also convert all of the printk() calls to use the dev_*() calls instead? That will also fix the problem that none of those calls in this driver are using the KERN_* levels for printk(), which is required.
Other than that minor thing, looks a lot better, thanks.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |