Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] slab.c cleanup | Date | Sun, 23 Mar 2003 22:24:10 +0100 |
| |
Brian Gerst wrote:
> Manfred Spraul wrote: >> >> No, the patch is a bad thing: It means that everyone who does >> kmalloc(32,) now allocates 128 bytes, i.e. 3/4 wasted. IMHO not acceptable. > > Perhaps, but it currently is already allocating 128 bytes for smaller > caches, because the cache is created with SLAB_HWCACHE_ALIGN. So we > ended up with redundantly sized caches.
Doesn't this code in kmem_cache_create() handle this already?
> if (flags & SLAB_HWCACHE_ALIGN) { > /* Need to adjust size so that objs are cache aligned. */ > /* Small obj size, can get at least two per cache line. */ > while (size < align/2) > align /= 2; > size = (size+align-1)&(~(align-1)); > }
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |