lkml.org 
[lkml]   [2003]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [CHECKER] races in 2.5.65/mm/swapfile.c?
Dawson Engler <engler@csl.stanford.edu> wrote:
>
> Hi All,
>
> mm/swapfile.c seems to have three potential races.
>
> The first two are in
> linux-2.5.62/mm/swap_state.c:87:add_to_swap_cache
>
> which seems reachable without a lock from the callchain:
>
> mm/swapfile.c:sys_swapoff:998->
> sys_swapoff:1026->
> try_to_unuse:591->
> mm/swap_state.c:read_swap_cache_async:377->
> add_to_swap_cache
>
> add_to_swap_cache increments two global variables without a lock:
> INC_CACHE_INFO(add_total);
> and
> INC_CACHE_INFO(exist_race);

These are just instrumentation. If they're a bit inaccurate nobody cares,
and they're not worth locking.

So yes, that is a positive.

> The final one is in
> linux-2.5.62/mm/swapfile.c:213:swap_entry_free
> which seems to increment
> nr_swap_pages++;
> without a lock.

swap_entry_free() is called after swap_info_get(), which locks the swap
device list and the particular swap device.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.065 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site