lkml.org 
[lkml]   [2003]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [CHECKER] potential dereference of user pointer errors
* Alan Cox (alan@lxorguk.ukuu.org.uk) wrote:
> On Fri, 2003-03-21 at 22:15, Chris Wright wrote:
> > on first pass of the cmd. However, this is inconsistent with the rest
> > of the file, so here is a patch to use kcmd.resbuf. I also added a NULL
> > check, as done in similar funcitons in this file. Alan, this look ok?
>
> Looks slightly wrong to me
>
> #1 ->resbuf = NULL is a completely acceptable if odd user choice. If invalid
> its covered

OK, I wasn't sure if it was valid. I noticed the other routines in that
file making similar checks.

> #2 - We copy to the users nominated cmd->resbuf. You are correct there,
> that we should be using the kernel side copy. Fixed in my tree.

Great, thanks.
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.103 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site