Messages in this thread | | | Date | Tue, 18 Mar 2003 17:29:18 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] dev_t [1/3] |
| |
On Tue, Mar 18, 2003 at 10:45:14PM +0100, Andries.Brouwer@cwi.nl wrote: > The first patch is the cdev-kill patch that I sent out > earlier. It is no use having two forms of chardev registration > in the source, and my version of the path of small modifications > does not pass through this version, although the final result > will not be that different. So, kill cdev_cachep, cdev_cache_init, > cdfind, cdget, cdput, inode->i_cdev, struct char_device. > All of this is dead code today.
You're also removing refcount code... why not fix it up instead?
I agree your patch is mostly correct from a "today" standpoint, but from a long term standpoint I think fixing up the code as intended would be the best path. It would be silly to remove this code only to add it again.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |