lkml.org 
[lkml]   [2003]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Ext2-devel] [PATCH] distributed counters for ext2 to avoid group scaning
    From
    Date
    >>>>> Matthew Wilcox (MW) writes:

    MW> Gah. That's your fault. Use diff -p in future; I saw:

    thanks for advice. I will.

    MW> which makes it look like the dcounters are added to ext2_bg_info.
    MW> diff -p would have put the name of the struct after the @@ line.
    MW> Not to mention you didn't follow the `s_' prefix style used
    MW> everywhere else in that struct.

    this makes sense too.

    MW> Anyway, I think dcounters should probably be allocated from
    MW> kmalloc_percpu() rather than as part of the dcounter struct.

    take a look.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:34    [W:0.019 / U:62.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site