[lkml]   [2003]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH] Fix stack usage for amd_flash.c
> On Fri, 14 March 2003 16:05:10 +0000, David Woodhouse wrote:
> > On Fri, 2003-03-14 at 15:46, Joern Engel wrote:
> >
> > Urgh. That should never have been on the stack in the first
> place. Make
> > it static. The comment about being deallocated when the
> probe is done is
> > bogus -- where do we think we get the contents of the table
> from when
> > _entering_ the probe function anyway? It's elsewhere in the kernel
> > image.

My bad, sorry.

> > Also note that all but the CFI-based drivers are deprecated. We have
> > old-style probes which allow us to use the CFI back-end drivers with
> > non-CFI chips anyway.
> Right. But since 2.[567] is going towards 4k kernel stack, those
> drivers should be fixed or revomed. If you don't remove it, I'll try
> to fix it. :)

We're still using the amd_flash-driver a lot because I haven't got time
to try out the jedec_probe since the toggle-bit stuff was added in the
CFI driver. I made some rough tests just before that, and jedec_probe +
CFI driver turned out to be much slower than amd_flash. But then the CFI
driver was modified... I'll try to get some time to test them again soon
and maybe even do something about it.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:34    [W:0.028 / U:3.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site