lkml.org 
[lkml]   [2003]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] remove BKL from ext2's readdir
Andrew Morton <akpm@digeo.com> wrote:
>
> Alex Tomas <bzzz@tmi.comex.ru> wrote:
> >
> >
> > hi!
> >
> > I took a look at readdir() in 2.5.64's ext2 and found it serialized by BKL.
>
> Yes, I had this in -mm for ages, seem to have lost it. Also removal of BKL
> from lseek().
>
> The theory is that the lock is there to avoid f_pos races against lseek. We
> ended up deciding that the way to address this is to ensure that all readdir
> implementations do:
>

hm, no. lseek is using the directory's i_sem now, and readdir runs
under that too. So we should be able to remove lock_kernel() from
the readdir implementation of all filesystems which are using
generic_file_llseek().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.025 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site