lkml.org 
[lkml]   [2003]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectmatroxfb_maven not being built in 2.4.21-pre5
Date

Hello,

I compiled a fresh 2.4.21-pre5 yesterday after using make oldconfig
on my old .config. Everything went smoothly for the most part,
except the matroxfb_maven.o and matroxfb_crtc2.o were not built.

The following changes to the Makefile are relevant:

< obj-$(CONFIG_FB_MATROX_MAVEN) += matroxfb_maven.o matroxfb_crtc2.o
< obj-$(CONFIG_FB_MATROX_G450) += matroxfb_g450.o matroxfb_crtc2.o
---
> ifeq ($(CONFIG_FB_MATROX_MAVEN),y)
> obj-$(CONFIG_FB_MATROX) += matroxfb_maven.o matroxfb_crtc2.o
> endif
> ifeq ($(CONFIG_FB_MATROX_G450),y)
> obj-$(CONFIG_FB_MATROX) += matroxfb_g450.o matroxfb_crtc2.o
> endif
> obj-$(CONFIG_FB_MATROX_PROC) += matroxfb_proc.o

I think the problem stems from the fact that if maven is compiled as a module,
only CONFIG_FB_MATROX_MAVEN_MODULE is defined, not CONFIG_FB_MATROX_MAVEN.
In any case, if I explicitly add the objects to be compiled, they compile
and work fine. So it looks like the conditional might need a little change.

Also, there does not seem to be a menuconfig entry for CONFIG_FB_MATROX_PROC.
Should there be?

--
Ryan Underwood, <nemesis at icequake.net>, icq=10317253
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.021 / U:33.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site