lkml.org 
[lkml]   [2003]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.4] Multiple memleaks in IBM Hot Plug Controller Driver
On Fri, Mar 14, 2003 at 09:34:44AM +0100, Björn Fahller wrote:
> On Thursday 13 March 2003 21.45, Oleg Drokin wrote:
>
> Below, why allocating 2 bytes on heap (str1,) only to non-conditionally free
> it a few lines further down? Why not keep the two bytes on stack instead? It
> also seems like a bad idea to strncopy/strcat 1 byte long strings.

Like I previously said, this whole function is a bad dream. Look at
what is now in 2.5, all of this nonsense is now gone.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.036 / U:38.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site