lkml.org 
[lkml]   [2003]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix stack usage in fs/intermezzo/journal.c
On Fri, 14 Mar 2003 17:44:45 +0100 Joern Engel <joern@wohnheim.fh-wedel.de> wrote:

| On Fri, 14 March 2003 08:09:30 -0800, Randy.Dunlap wrote:
| >
| > I guess one of us needs some guidance here.
| > I thought that sizeof(*buf) == 1 here, not 4096. Anybody?
| > I don't see how sizeof() can determine the kmalloc-ed size,
| > so I would use BUF_SIZE instead, with
| > #define BUF_SIZE 4096
|
| I'd love to say you're wrong, but you're not. New patch is below.
| FUNCTION_NAME_BUFSIZE should have less name collision than BUF_SIZE,
| but someone who knows intermezzo better than me might find a much
| nicer name.

If you are concerned about namespace & collisions, you can
#undef BUF_SIZE
after each function.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.037 / U:12.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site