lkml.org 
[lkml]   [2003]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpu/hw_random cleanups
On Thu, Mar 13, 2003 at 12:06:16PM -0800, H. Peter Anvin wrote:
> Jeff Garzik wrote:
> >For x86 experts, the new cpu cap words are what needs looking over.
> >For example, I wonder if storing Intel's cpuid(0x00000001) ecx
> >register output is wise on older Intel cpus. I worry about garbage
> >appearing there. Is that a false worry?
> >
>
> Yes; it should be completely safe.

noted


> >===== arch/i386/kernel/cpu/centaur.c 1.7 vs edited =====
> >--- 1.7/arch/i386/kernel/cpu/centaur.c Tue Mar 11 21:35:40 2003
> >+++ edited/arch/i386/kernel/cpu/centaur.c Thu Mar 13 13:31:08 2003
> >@@ -256,9 +256,10 @@
> > if (cpuid_eax(0xC0000000) >= 0xC0000001) {
> > set_bit(X86_FEATURE_CENTAUR_EFF, c->x86_capability);
> >
>
> There is also no need to set a special feature bit for the existence of
> the feature flags. If they are not present the additional capability
> word will simply be zero.

Thanks, fixed.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.052 / U:10.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site