Messages in this thread | | | Date | Wed, 12 Mar 2003 00:48:01 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] fix big initramfs (was: [PATCH] gen_init_cpio fixes for 2.5.64) |
| |
Anders Gustafsson <andersg@0x63.nu> wrote: > > Patch below makes the call to page_writeback_init() explicit in > start_kernel, just before populate_rootfs(). >
Fair enough.
> +extern void page_writeback_init(void);
But please don't put declarations of external functions into .c. It is always the wrong thing to do, even though others have done it...
writeback.h is a fine place for this declaration. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |