lkml.org 
[lkml]   [2003]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] don't ignore chipset specific sector size (Was Re: bio too big device)
	Hello,

On Wed, 12 Mar 2003, Manfred Spraul wrote:

> linux/drivers/ide/ide-probe.c:
>
> >#ifdef CONFIG_BLK_DEV_PDC4030
> > max_sectors = 127;
> >#else
> > max_sectors = 255;
> >#endif
> > blk_queue_max_sectors(q, max_sectors);
> >
> >
> >
> IDE uses 127 sector requests if support for PDC4030 is compiled it,
> otherwise 255. It seems someone started with a blacklist, but never
> completed it.

There is something wrong with this.

2.4.20-pre5-ac1 for example does:
*max_sect++ = ((hwif->rqsize) ? hwif->rqsize : 128);
(hmm why 128?)

PDC4030 (127 sectors) and siimage (128 or 16) are setting own sector size,
so this may be related to
http://bugzilla.kernel.org/show_bug.cgi?id=123.

Not tested patch (sorry, no hardware) agains 2.5.64-ac3 (applies to 2.5.64
too).

--
have fun,
alex

===== drivers/ide/ide-probe.c 1.33 vs edited =====
--- 1.33/drivers/ide/ide-probe.c Sat Mar 8 01:45:31 2003
+++ edited/drivers/ide/ide-probe.c Wed Mar 12 23:12:35 2003
@@ -995,18 +995,15 @@
static void ide_init_queue(ide_drive_t *drive)
{
request_queue_t *q = &drive->queue;
- int max_sectors;
+ int max_sectors = 255;

q->queuedata = HWGROUP(drive);
blk_init_queue(q, do_ide_request, &ide_lock);
drive->queue_setup = 1;
blk_queue_segment_boundary(q, 0xffff);

-#ifdef CONFIG_BLK_DEV_PDC4030
- max_sectors = 127;
-#else
- max_sectors = 255;
-#endif
+ if (HWIF(drive)->rqsize)
+ max_sectors = HWIF(drive)->rqsize;
blk_queue_max_sectors(q, max_sectors);

/* IDE DMA can do PRD_ENTRIES number of segments. */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.042 / U:12.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site