[lkml]   [2003]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectComments on latest PNP changes.
	Hello Adam and other.
1) Mem leak in your rewrite of als100
+ err = pnp_activate_dev(pdev);
+ if (err < 0) {
+ printk(KERN_ERR PFX "AUDIO pnp configure failure\n");
+ return err;
+ }
Here you've forgot add "kfree(cfg);"
2) And here
+MODULE_DEVICE_TABLE(pnp_card, snd_als100_pnpids);
type must of entries must end with "device_id", but you've changed type
from "pnp_card_device_id" to "pnp_card_id". This changes broke
3) When I need to activate(dev)?
Thanks, Ruslan.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:33    [W:0.022 / U:8.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site