Messages in this thread | | | Date | Tue, 11 Mar 2003 08:44:26 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] kernel/rcupdate.c microcleanup |
| |
On Tue, 11 Mar 2003, Andrey Panin wrote: > > attached patch (2.5.64) contains small cleanup of RCU code: > - move smp_processor_id() outside of irq disabled region in call_rcu();
That looks wrong, and is likely to break with preemption, since the caller could potentially be moved to another CPU between the smp_processor_id() and the irq disable.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |