lkml.org 
[lkml]   [2003]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[Script] Changing the printk()s without KERNEL_ specification
Date
Hello everybody,

Here's the latest version of my script.
I no longer advertise the patches as they are pretty big - for 2.5.64 it's
109022L and 3970383C.704649
bzip2'ed still 700KB - so I'm posting my script instead.

As some weeks ago it searches for occurrences of printk() without KERNEL_* -
specifications (eg KERNEL_DEBUG) and changes these. It tries to be
intelligent about that, ie it tracks if the last printk() in this function
had a \n at the end or not - continued lines shouldn't be messed up with <?>
characters.

This script couldn't parse the files (functions)
./fs/umsdos/mangle.c (umsdos_manglename)
./fs/affs/super.c (affs_write_super)
./sound/oss/emu10k1/audio.c (emu10k1_audio_ioctl)
./sound/oss/sb_ess.c (ess_init)
./sound/isa/sb/sb16.c (snd_sb16_probe)
./sound/isa/opti9xx/opti92x-ad1848.c (snd_card_opti9xx_probe)
and
./lib/zlib_deflate/deftree.c
- the first few because of #ifdef tricks with { or } and the last because of a
#define.

In
./lib/zlib_deflate/deftree.c
it correctly inserts a KERNEL_DEBUG - but as this printk() is the first in
this function AND in a loop you'll have to use this patch:

diff -u crypto/tcrypt.c.orig crypto/tcrypt.c
--- crypto/tcrypt.c.orig Wed Mar 5 04:29:33 2003
+++ crypto/tcrypt.c Mon Mar 10 15:43:16 2003
@@ -55,6 +55,8 @@
static void
hexdump(unsigned char *buf, unsigned int len)
{
+ printk(KERNEL_DEBUG);
+
while (len--)
printk("%02x", *buf++);

to make my script work.

Usage is like
find . -iname "*.c" | xargs perl -i.bak ~/perl/change_printk.pl
so parts of the tree can be changed as well as the full tree.

Please let me know if you're using this script (just for my pride :-) and let
me also know every problem you encounter.



Regards,

Phil

#!/usr/bin/perl


@DEAD=();

undef $/; # read complete files
file:
while (<>)
{
print STDERR $ARGV,"\n";
# read functions
$fpos=0;
while ( ($name)=
(m/(\w+)\s*\([^)]+?\)\s*(\x7b)/m) )
# can't use open-curly-bracket because of auto-indent
{
$start=$-[2];
$body=substr($_,$start);

$fpos+=$start;

$index=1;
$level=1;
while($level)
{
$l_o=index($body,'{',$index);
$l_c=index($body,'}',$index);
print STDERR "found: $l_o $l_c \n" ; #in <$body>\n";
if ($l_c < 0)
{
push @DEAD,"$ARGV:$name:$fpos";
print $_;
next file;
}

if ($l_c < $l_o || $l_o<0)
{
$level--;
$index=$l_c+1;
}
else
{
$level++;
$index=$l_o+1;
}
}

$text= substr($body,0,$index);
print substr($_,0,$start),&Change($ARGV,$name,$text);
substr($_,0,$start+$index)="";
$fpos+=$index;
}

print $_;
}


if (@DEAD)
{
print STDERR "\n\nDEAD FILES: ******************\n";
print STDERR join("\n",@DEAD,"");
}

exit;


sub Change
{
my($file,$func,$txt)=@_;
my($sol,$index,$pk,$fmt,$parm,$is_kern,$e);
my(%insert);


$sol=1; # start of line set for function start

%insert=(); # indizes to insert KERN_-values
$index=-1;
while (1)
{
print STDERR "$file:$func:$index\n";
$index=index($txt,"printk",$index+1);
last if $index == -1;

if (substr($txt,$index-1,256) !~ m#\b(printk\s*\x28\s*)(\S[^,\x29]+\S)(\s*,[\x00-\xff]+?\S)?\s*\x29\s*;#)
{
# not a real printk
next;
}

($pk,$fmt,$parm)=($1,$2,$3);
$is_kern= $fmt =~ m#^KERN_#;

if ($sol)
{
if ($is_kern)
{
# ok
}
else
{
# KERN_DEBUG missing
$insert{$index + length($pk)}=" KERN_DEBUG ";
}
}
else
{
if ($is_kern)
{
warn "possibly too much KERN_* at $file:$func:$index\n";
}
else
{
# ok
}
}

# find \n in strings, and append a KERN_DEBUG if there's no " after \n
$insert{$index + length($pk) + length($1)} = '" KERN_DEBUG "'
while ($fmt =~ m#^([\x00-\xff]*\\n)(?!")#g);

$sol = $fmt =~ m#\\n"$#;
}

# from end to start, to avoid invalidating the indizes
for (sort { $b <=> $a } keys %insert)
{
substr($txt,$_,0)=$insert{$_}
}

$txt;
}


__END__

while ( $txt =~ s#\b(printk\s*\x28\s*)(")#$1 KERN_DEBUG $2 #gx)
{
print STDERR "in $file:$func:$txt\n";
}

## vim: sw=2
\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.066 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site