[lkml]   [2003]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH][2.5] rename vector to irq
Variable renaming may be generally frowned upon, but i think the variable 
name 'vector' really confuses things at this specific code location seeing
as it's not actually a vector as referred to for the IDT. With the
idt_descr and irq_entries_start being really closely knit it can really
confuse someone new to the code.

Index: linux-2.5.62-lse/arch/i386/kernel/entry.S
RCS file: /build/cvsroot/linux-2.5.62/arch/i386/kernel/entry.S,v
retrieving revision
diff -u -r1.1.1.1 entry.S
--- linux-2.5.62-lse/arch/i386/kernel/entry.S 18 Feb 2003 00:16:06 -0000
+++ linux-2.5.62-lse/arch/i386/kernel/entry.S 1 Mar 2003 06:58:39 -0000
@@ -376,16 +376,16 @@

.rept NR_IRQS
-1: pushl $vector-256
+1: pushl $irq-256
jmp common_interrupt
.long 1b

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at
 \ /
  Last update: 2005-03-22 13:33    [W:0.024 / U:1.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site