Messages in this thread | | | Date | Sun, 9 Feb 2003 12:03:58 +0000 | From | John Levon <> | Subject | Re: Switch APIC (+nmi, +oprofile) to driver model |
| |
On Sun, Feb 09, 2003 at 12:32:01PM +0100, Pavel Machek wrote:
> static void nmi_shutdown(void) > { > - unset_nmi_pm_callback(oprofile_pmdev); > + nmi_enabled = 0; > unset_nmi_callback(); > smp_call_function(nmi_cpu_shutdown, NULL, 0, 1); > nmi_cpu_shutdown(0); > + if (nmi_watchdog == NMI_LOCAL_APIC_SUSPENDED_BY_OPROFILE) { > + nmi_watchdog = NMI_LOCAL_APIC_SUSPENDED_BY_OPROFILE; > + setup_apic_nmi_watchdog(); > + }
It looks to me like you'll end up enabilng the watchdog even if user didn't enable the watchdog at boot up. Also, setup_apic_nmi_watchdog() and the disable function need to exported to modules.
john - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |