lkml.org 
[lkml]   [2003]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] 2.5.59 : drivers/char/ite_gpio.c
Date
In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write:
> --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
> +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
> @@ -140,7 +140,7 @@
> {
> int ret=-1;
>
> - if (MAX_GPIO_LINE > *data >= 0)
> + if ((MAX_GPIO_LINE > *data) && (*data >= 0))
> ret=ite_gpio_irq_pending[*data];
>
> DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));

Nope, of course *data is >= 0, it's a u32.

Once again, the author needs to indicate (and test!) what was meant
here...

Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.048 / U:8.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site