Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | Re: [PATCH] 2.5.59 : drivers/char/ip2/i2lib.c | Date | Mon, 10 Feb 2003 11:27:24 +1100 |
| |
In message <Pine.LNX.4.44.0302071214440.6917-100000@master> you write: > Hello all, > The following patch addresses buzilla bug # 320, and separates 1 test > into 2 separate 2 tests. Please review for inclusion.
The old code was nonsensical, so I can't trivially tell if the new code is right. This has to be done by the author.
With no '@' sign anywhere in the char/ip2 subdirectory, I have no idea who to send this to 8(
Rusty.
> --- linux/drivers/char/ip2/i2lib.c.old 2003-01-16 21:22:57.000000000 -0500 > +++ linux/drivers/char/ip2/i2lib.c 2003-02-07 02:54:36.000000000 -0500 > @@ -1251,7 +1251,7 @@ > > } > if ( old_flags & STOPFL_FLAG ) { > - if ( 1 == i2QueueCommands(PTYPE_INLINE, pCh, 0, 1, CMD_STOPFL) > 0 ) { > + if ((1 == i2QueueCommands(PTYPE_INLINE, pCh, 0, 1, CMD_STOPFL)) && (i2QueueCommands(PTYPE_INLINE, pCh, 0, 1, CMD_STOPFL) > 0 )) { > old_flags = 0; // Success - clear flags > } > >
-- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |