lkml.org 
[lkml]   [2003]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] do_mounts memory leak
Hi,

The Stanford Checker identified a memory leak in
init/do_mounts.c. This patch to 2.5.59 corrects it.
Please apply.

Thanks,
~Randydiff -Naur ./init/do_mounts.c%LEAK ./init/do_mounts.c
--- ./init/do_mounts.c%LEAK Thu Jan 16 18:22:02 2003
+++ ./init/do_mounts.c Tue Feb 4 21:46:58 2003
@@ -653,12 +653,6 @@
/*
* OK, time to copy in the data
*/
- buf = kmalloc(BLOCK_SIZE, GFP_KERNEL);
- if (buf == 0) {
- printk(KERN_ERR "RAMDISK: could not allocate buffer\n");
- goto done;
- }
-
if (sys_ioctl(in_fd, BLKGETSIZE, (unsigned long)&devblocks) < 0)
devblocks = 0;
else
@@ -669,6 +663,12 @@

if (devblocks == 0) {
printk(KERN_ERR "RAMDISK: could not determine device size\n");
+ goto done;
+ }
+
+ buf = kmalloc(BLOCK_SIZE, GFP_KERNEL);
+ if (buf == 0) {
+ printk(KERN_ERR "RAMDISK: could not allocate buffer\n");
goto done;
}
\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.029 / U:2.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site