lkml.org 
[lkml]   [2003]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa, pnp] more on opl3sa2 (fwd)
On Thu, 30 Jan 2003, Adam Belay wrote:

> Hi Jaroslav,
>
> How does this sound...
>
> What if we make pnp card services match against all pnp cards and allow more
> than one card driver to use the same card. This can be accomplished if we detach
> the card portion from the driver model and use driver_attach. If you feel it is

The question is probably another. I know that your solution will work, but
do we need such hack against the driver model in our code? If you work
with cards as buses, it allows us the same model as PCI code.

> necessary, we could also add an optional card id to the pnp_device_id structure.
> As for the pnpbios, I disagree with putting it under one card. If the pnpbios
> contains two opl3sa2 sound cards then only one will be matched and therefore it

It's not true. The driver model calls probe for all instances.

> is a bad idea to represent the pnpbios as a card. When ACPI is introduced, both

Note that if we make card as bus, then this problem will disapear.
The enumeration will be simple: devices on the one bus. And it's strong
advantage over current implementation when bus == protocol.

What do you think about this model:

bus (PnP BIOS) -> devices
bus (ACPI) -> devices
bus (ISA PnP) -> bus (cards) -> devices

To allow grouping of card devices, we can use the driver_attach() function
from the probe() callback.

Also, the current pnp_protocol should be detached from the driver model.
I think that it's internal thing for the PnP device management.

> pnpbios and ACPI will be cardless protocols. Therefore I think it is best to
> use the pnp_driver structure instead of the pnpc_driver structure in the
> opl3sa2 ALSA driver.

The opl3sa2 driver is an exception. All others will require groups of
devices.

Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.054 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site