lkml.org 
[lkml]   [2003]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: ioctl32 consolidation -- call for testing
    Hi!

    > > > Well, you just doubled the size of the table on sparc64.
    > > > I don't know if I like that.
    > >
    > > Not much of a way around it.
    > >
    > > Such problems are only in your mind. :-)
    > >
    > > What's wrong with defining the type and accessor macros
    > > in include/asm/compat.h?
    >
    > One thing I am just now wondering is why struct ioctl_trans defines cmd
    > as an unsigned long instead of just unsigned int. That adds an uneeded
    > bit of space to the array.

    Do you think so?

    cmd probably could be u32 (since it is ioctl32 after all), but I doubt
    it matters, as two following entries are pointers so it looks to me
    like it is going to be lost by alignment, anyway.

    > As for your suggestion, sounds great, but I'll leave it to Pavel :)

    First things first, patch probably still breaks all other
    architectures than x86-64 and sparc64....
    Pavel
    --
    Horseback riding is like software...
    ...vgf orggre jura vgf serr.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.021 / U:59.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site