lkml.org 
[lkml]   [2003]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH 3/8] dm: prevent possible buffer overflow in ioctl interface
    Date
    On Thursday 27 February 2003 10:25, Roland Dreier wrote:
    > > + char *name = kmalloc(DM_NAME_LEN + strlen(DM_DIR) + 1);
    > > + if (!name) {
    > > + return -ENOMEM;
    > > + }
    >
    > Also, kmalloc() needs a second "GFP_xxx" parameter (I guess GFP_KERNEL
    > in this case, although I don't know the context this function is
    > called from).
    >
    > - Roland

    Dammit! I'm not having a good morning. :(

    Unfortunately, Linus seems to have committed that patch already. So here is a
    patch to fix just that line.

    Thanks for catching that.

    --
    Kevin Corry
    corryk@us.ibm.com
    http://evms.sourceforge.net/

    --- a/drivers/md/dm-ioctl.c 2003/02/27 16:29:58
    +++ b/drivers/md/dm-ioctl.c 2003/02/27 16:30:03
    @@ -174,7 +174,7 @@
    static int register_with_devfs(struct hash_cell *hc)
    {
    struct gendisk *disk = dm_disk(hc->md);
    - char *name = kmalloc(DM_NAME_LEN + strlen(DM_DIR) + 1);
    + char *name = kmalloc(DM_NAME_LEN + strlen(DM_DIR) + 1, GFP_KERNEL);
    if (!name) {
    return -ENOMEM;
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.019 / U:59.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site