lkml.org 
[lkml]   [2003]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kernel Ooops (2.5.63 bk latest)
Maneesh Soni <maneesh@in.ibm.com> wrote:
>
> ref is taken in d_validate, which is called before using the smbfs cached
> dentry. It is this ref which is taken back in smb_readdir().

hmm, thinking about this a bit more...

It appears that d_validate's role in life is to take some random pointer
which the caller thinks might be a dentry and to verify that it is indeed
still a valid dentry (or a totally new dentry at the same address!). If
so, pin that dentry and tell the user.

Perhaps the dentry's address was received across the network, although it
doesn't look that way.

In which case passing in a might-be pointer to a zero-ref dentry is
appropriate and your patch is OK. One would need some understanding of ncpfs
and smbfs to say for sure.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.027 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site