lkml.org 
[lkml]   [2003]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][2.5] fix preempt-issues with smp_call_function()
Thomas Schlichter <schlicht@uni-mannheim.de> wrote:
>
> Hello,
>
> here is a patch to solve all (I hope I missed none) possible problems that
> could occur on SMP machines running a preemptible kernel when
> smp_call_function() calls a function which should be also executed on the
> current processor.
>

Patch looks pretty good, thanks. Fixes a real bug.

I worry a little about the s390/s390x change. smp_ctl_set_bit() and
smp_ctl_clear_bit(). The functions which are being called on local and
remote are fairly different. I'm sure it's OK, but... I changed that bit
to open-code the preempt_disable/enable.

The arch/x86_64/kernel/bluesmoke.c change looks right. Seems that someone
didn't understand the smp_call_function() API in there.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.049 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site