lkml.org 
[lkml]   [2003]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Use hex numbers in fs/block_dev.c
    Date
    We're using hex numbers to identify devices in most places. We should use
    them in filesystem messages, errors etc. too, this would be much more
    consistent and avoids things like this where two different naming styles
    for the same error are used:

    end_request: [...] dev 16:45 (hdd), sector 9175248
    EXT3-fs error (device ide1(22,69)): [...] inode=575269, block=1146906

    With this patch the second message would look like this:

    EXT3-fs error (device ide1(16:45)): [...] inode=575269, block=1146906

    This code is used in some drivers outside fs/ too, but there only in *print*
    or DEBUG's.

    Eike

    --- linux-2.5.63-eike/fs/block_dev.c.orig Tue Feb 25 08:15:45 2003
    +++ linux-2.5.63-eike/fs/block_dev.c Wed Feb 26 16:04:28 2003
    @@ -794,7 +794,7 @@
    if (!name)
    name = "unknown-block";

    - sprintf(buffer, "%s(%d,%d)", name, MAJOR(dev), MINOR(dev));
    + sprintf(buffer, "%s(%x:%x)", name, MAJOR(dev), MINOR(dev));
    return buffer;
    }

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.018 / U:31.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site