lkml.org 
[lkml]   [2003]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] IPv6: Privacy Extensions for Stateless Address Autoconfiguration in IPv6
On Wed, Feb 26, 2003 at 12:36:25AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B wrote:
> +#
> +if [ "$CONFIG_IPV6_PRIVACY" = "y" ]; then
> + if [ "$CONFIG_IPV6" = "y" ]; then
> + define_tristate CONFIG_MD5 y
> + else
> + define_tristate CONFIG_MD5 m
> + fi
> +else
> + tristate 'MD5 digest support' CONFIG_MD5
> +fi

Config.in files use three-space indents.

> +obj-$(CONFIG_MD5) += md5.o
> +ifeq ($(CONFIG_MD5),y)
> + export-objs += md5.o
> +endif

this is wrong, objects are added to export-objs unconditional.

> +
> +#ifdef CONFIG_MD5
> +EXPORT_SYMBOL(MD5Init);
> +EXPORT_SYMBOL(MD5Update);
> +EXPORT_SYMBOL(MD5Final);
> +EXPORT_SYMBOL(MD5Transform);
> +#endif

Please remove the ifdef, it doesn't make any sense.


Also I really wonder whether we want to add just md5.c to 2.4 or
backport the cryptoapi core with md5 as the only algorithm so far..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.063 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site