lkml.org 
[lkml]   [2003]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] eliminate warnings in generated module files
On Wed, 26 Feb 2003, Rusty Russell wrote:

> In message <Pine.LNX.4.44.0302251546590.2185-100000@home.transmeta.com> you wri
> te:
> >
> > On Tue, 25 Feb 2003, Rusty Russell wrote:
> > >
> > > __optional should always be __attribute__((__unused__)), and
> > > __required should be your __attribute_used__.
> >
> > But I think rth's point was that "__module_depends" should definitely
> > _not_ be "optional", since that just means that the compiler can (and
> > will) optimize away the whole thing.
> >
> > So marking it optional is definitely the wrong thing to do.
>
> This time for sure!

FWIW, I think it's not a good idea. Why call it 'required' in the kernel
when the normal (gcc) expression for it is 'used'. - We didn't rename
'deprecated' to 'obsolete', either ;)

Also, I don't really see any use for __optional at this point, so why add
it at all?

So IMO, the only change which possibly makes sense is to rename
__attribute_used__ to __used, since it makes it more consistent with
similar things like __deprecated, __init, __exit etc.

--Kai


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.061 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site