Messages in this thread | | | Date | Tue, 25 Feb 2003 13:40:43 -0800 | From | William Lee Irwin III <> | Subject | Re: cpu-2.5.63-1 |
| |
On Tue, Feb 25, 2003 at 01:32:07PM -0800, Randy.Dunlap wrote: - if (target_cpu_mask & allowed_mask) { + if (cpus_empty(tmp)) { # ? if (!cpus_empty(tmp)) {
Yep, that's a bug.
On Tue, Feb 25, 2003 at 01:32:07PM -0800, Randy.Dunlap wrote: -#define BITS_TO_LONGS(bits) \ - (((bits)+BITS_PER_LONG-1)/BITS_PER_LONG) # keep this and use it. (but moved from another file) +#define DECLARE_BITMAP(name,bits) \ + unsigned long name[((bits)+BITS_PER_LONG-1)/BITS_PER_LONG] # unsigned long name[BITS_TO_LONGS(bits)] +#define CLEAR_BITMAP(name,bits) \ + memset(name, 0, ((bits)+BITS_PER_LONG-1)/8) # memset(name, 0, BITS_TO_LONGS(bits) * (BITS_PER_LONG / 8)) # This clears all longs in <name>, so that extra code below can disappear.
Header ordering stuff. A wee bit brute-force. All good cleanups. You originally spotted the bitmap_fill() typo too.
Looks like time for a cpu-2.5.63-2 with your changes.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |