lkml.org 
[lkml]   [2003]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] comments on st_blksize and f_bsize for 2.5
Andries Brouwer wrote:

>On Tue, Feb 18, 2003 at 08:25:40PM +0300, Hans Reiser wrote:
>
>
>
>>Since a few applications, and the linux manpages, seem to not really
>>understand what these are for, they need comments like SUSv2 has for
>>them. A larger discussion will be provided if requested.
>>
>>
>
>
>
>>+ unsigned int st_blksize; /* Optimal I/O size */
>>
>>
>
>
>
>>+ int f_bsize; /* Filesystem blocksize */
>>
>>
>
>Yes, discussion - I wouldnt mind seeing details.
>
>The trivial part is st_blksize: all agree.
>Quoting the man page:
>
> The value st_blksize gives the "preferred" blocksize
> for efficient file system I/O. (Writing to a file in
> smaller chunks may cause an inefficient read-modify-rewrite.)
>
Oh my, I must confess that we read just the comment on the struct in the
manpage:

blksize_t st_blksize; /* blocksize for filesystem
I/O */

and not the text below it which is correct if less clear than it could be.

How about using our comment on the struct on the manpage as it is more
clear?


How about instead saying in the manpage body:

Historically, st_blksize was the block size, and applications would do
I/O's at that size for greater efficiency of IO. Now, after some
evolution, st_blksize represents the most efficient size of an IO to
that file, and no longer always represents the actual size of blocks in
the underlying filesystem.


Or you could even use the longer comment on the struct, but then I have
always liked lng comments more than most....;-)

--
Hans


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.039 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site