lkml.org 
[lkml]   [2003]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] USB speedtouch: better proc info
Date
Am Montag, 24. Februar 2003 10:58 schrieb Duncan Sands:
> Output the correct device name, show the state of the device (for
> debugging) and of the ADSL line (anyone want to write a graphical utility
> to show this, like under windows?). We no longer consult the usb_device
> struct in udsl_atm_proc_read, so don't take a reference to it. Against
> Greg's current 2.5 USB tree.

First of all, let me say that you're doing wonders with this driver.
But this particular patch I don't like. It improves stuff that should
be removed. More specifically:

1. Does anything prevent you from using the medium detection
hooks the network layer provides?
2. What need is there to export manufacturer id and mac address
again?
3. Doesn't the rest belong into sysfs rather than procfs?

Regards
Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.037 / U:1.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site