lkml.org 
[lkml]   [2003]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectBUG? SA_INTERRUPT and shared IRQs
i'm having a problem with crashes which i think is to do with shared 
irq's. i have too many things hanging off my PCI bus... dammit.

on IRQ 19 i have:
wlan0 (prism2 based wireless card running hostap)
ens1371 (soundcard)
uhci-hcd (USB driver)

wlan0 and uhci-hcd call request_irq with SA_SHIRQ
ens1371 calles request_irq with SA_SHIRQ | SA_INTERRUPT

the code that calls the interrupt handlers appears to be:
(arch/i386/kernel/irq.c)

int handle_IRQ_event(unsigned int irq, struct pt_regs * regs, struct
irqaction * action)
{
int status = 1; /* Force the "do bottom halves" bit */

if (!(action->flags & SA_INTERRUPT))
local_irq_enable();

do {
status |= action->flags;
action->handler(irq, action->dev_id, regs);
action = action->next;
} while (action);
if (status & SA_SAMPLE_RANDOM)
add_interrupt_randomness(irq);
local_irq_disable();

return status;
}

which looks to me that interrupts are going to get enabled if the
_first_ handler in the chain _doesn't_ have SA_INTERRUPT set, which
isn't the behaviour i'd expect. a later handler might freak if it makes
the assumption that interrupts are disabled (or maybe this doesn't
happen)...

i'm not sure what the correct thing to do here is... is it okay to
enable or disable interrupts for each handler depending on their own
SA_INTERRUPT flag? if that's the case then the patch is trivial...

thanks

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.024 / U:8.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site