lkml.org 
[lkml]   [2003]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Longstanding networking / SMP issue? (duplextest)
From
   From: Christoph Hellwig <hch@infradead.org>
Date: Sun, 23 Feb 2003 10:02:34 +0000

> + icmp_xmit_lock();

Hmm, and I guess the code would be much more readable if you used
the spin_lock call directly. The impliclit icmp_socket doesn't
really help readability either.

Sure it does, it encapsulates the icmp_socket->sk->foo->far->fum
dereferencing into one place instead of 4.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.480 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site