lkml.org 
[lkml]   [2003]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ioctl32 consolidation
At 02:31 PM 2/20/2003, Pavel Machek wrote:
>Hi!
>
>Currently, 32-bit emulation in kernel has *5* copies, and its >1000
>lines each. Plus, locking of all but x86-64 architectures is broken
>(I'm told by andi ;-).
>
>So, here's patch that starts sharing sys32_ioctl() [as a first step],
>which should rmove locking problems.
>
>I've done the work for x86-64 and sparc64; if it looks good I'll
>attempt to do other architectures. [Unless maintainers prefer to do it
>themselves: I don't have easy access to 64-bit machines besides
>hammer.]

Nice. I'm glad that somebody started looking at this (I was going to work
on that but didn't have time for it).
Patch looks ok to me.

Eventually we'll be able to kill ugly mess like arch/sparc64/kernel/ioctl32.c.
That stuff really belongs to the actual subsystems that implement those ioctls.

Thanks
Max

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.055 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site