Messages in this thread | | | Date | Thu, 20 Feb 2003 20:50:17 +0000 | From | Dave Jones <> | Subject | Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all() |
| |
On Thu, Feb 20, 2003 at 09:30:55PM +0100, Thomas Schlichter wrote:
> > This looks bogus. You're killing the wbinvd() in flush_kernel_map() which > > is needed. > I must admit I don't exactly know the wbinvd() command, but as the comment > says: > /* Could use CLFLUSH here if the CPU supports it (Hammer,P4) */ > > I thought it is not NEEDED, just a COULD...
Its hinting at a possible optimisation, not saying that it is unneeded.
Dave
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |