lkml.org 
[lkml]   [2003]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix bug 376 - tiny extra echo in Makefile
On Thu, 20 Feb 2003, Muli Ben-Yehuda wrote:

> It's not really a bug, which means this isn't really a fix, but it
> does make things more consistent. Please consider for inclusion or let
> me know you aren't interested so I can close the bug. Thanks.
>
> # This is a BitKeeper generated patch for the following project:
> # Project Name: Linux kernel tree
> # This patch format is intended for GNU patch command version 2.5 or higher.
> # This patch includes the following deltas:
> # ChangeSet 1.1004 -> 1.1005
> # Makefile 1.362 -> 1.363
> #
> # The following is the BitKeeper ChangeSet Log
> # --------------------------------------------
> # 03/02/20 mulix@alhambra.mulix.org 1.1005
> # don't print the echo command when printing 'Generating build number'
> # --------------------------------------------
> #
> diff -Nru a/Makefile b/Makefile
> --- a/Makefile Thu Feb 20 13:40:59 2003
> +++ b/Makefile Thu Feb 20 13:40:59 2003
> @@ -325,7 +325,7 @@
> define rule_vmlinux__
> set -e
> $(if $(filter .tmp_kallsyms%,$^),,
> - echo ' Generating build number'
> + @echo ' Generating build number'
> . $(src)/scripts/mkversion > .tmp_version
> mv -f .tmp_version .version
> $(Q)$(MAKE) $(build)=init

The thing is, I cannot reproduce it here.

Also, the entire rule_vmlinux__ is invoked with a '@' in front, so nothing
there should be echoed. However, for the original submitter that obviously
doesn't work, the ". $(src)..." line is echoed to. What version of "make"
is used?

--Kai


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.030 / U:7.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site